Skip to content

Related Posts: Prevent PHP warnings when settings are malformed #45538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 20, 2025
Merged

Related Posts: Prevent PHP warnings when settings are malformed #45538

merged 4 commits into from
Oct 20, 2025

Conversation

@tbradsha
Copy link
Contributor

@tbradsha tbradsha commented Oct 17, 2025 •
edited by robertsreberski
Loading

Closes MONOREP-156

This addresses the following warnings:

PHP Warning: Trying to access array offset on false in /wordpress/plugins/jetpack/15.2-a.1/modules/related-posts/jetpack-related-posts.php on line 201
PHP Warning: Trying to access array offset on false in /wordpress/plugins/jetpack/15.2-a.1/modules/related-posts/jetpack-related-posts.php on line 934
PHP Warning: Trying to access array offset on false in /wordpress/plugins/jetpack/15.2-a.1/modules/related-posts/jetpack-related-posts.php on line 1308
PHP Warning: Trying to access array offset on false in /wordpress/plugins/jetpack/15.2-a.1/modules/related-posts/jetpack-related-posts.php on line 1309
PHP Warning: Trying to access array offset on false in /wordpress/plugins/jetpack/15.2-a.1/modules/related-posts/jetpack-related-posts.php on line 1310
PHP Warning: Trying to access array offset on false in /wordpress/plugins/jetpack/15.2-a.1/modules/related-posts/jetpack-related-posts.php on line 1311
PHP Warning: Trying to access array offset on false in /wordpress/plugins/jetpack/15.2-a.1/modules/related-posts/jetpack-related-posts.php on line 1312
PHP Warning: Trying to access array offset on false in /wordpress/plugins/jetpack/15.2-a.1/modules/related-posts/jetpack-related-posts.php on line 1316

These are due to settings being malformed. I've largely set things to use the defaults as the fallback with null coalescence. At some point the module should have more robust validation, but that's out of scope here.

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

I'm not sure the best way to reproduce. Verify that the code changes will address the immediate concern.

@tbradsha tbradsha requested a review from a team October 17, 2025 19:07
@tbradsha tbradsha self-assigned this Oct 17, 2025
@tbradsha tbradsha added [Status] Needs Review This PR is ready for review. [Type] Janitorial labels Oct 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/related-posts/warnings branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/related-posts/warnings

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Related Posts [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Oct 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: November 4, 2025
    • Code freeze: November 3, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control
Copy link

jp-launch-control bot commented Oct 17, 2025 •
edited
Loading

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@tbradsha tbradsha merged commit d3dea22 into trunk Oct 20, 2025
67 checks passed
@tbradsha tbradsha deleted the fix/related-posts/warnings branch October 20, 2025 13:11
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Oct 20, 2025
@github-actions github-actions bot added this to the jetpack/15.2 milestone Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tbradsha tbradsha

Labels

[Feature] Related Posts [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Janitorial

Projects

None yet

Milestone

jetpack/15.2

Development

Successfully merging this pull request may close these issues.

2 participants

@tbradsha